Change birthdate to age #937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…kmcgill/hackerAPI into feat/change_birthdate_to_age
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
allennatang
had a problem deploying
to
testing
GitHub Actions
Failure
|
The most recent commit also contains the changes for this related dashboard issue hackmcgill/dashboard#1013 where I added a country of residence field to the hacker application. In the hackerAPI, I added validation (checking that the field is not empty) and I also added it to the example api data (not sure if that was necessary, but doesn't do anything). |
tektaxi
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tickets:
#936
Related to dashboard issue: hackmcgill/dashboard#1003
List of changes:
Changed hacker account's birthdate field to age field to match MLH guidelines.
Created function
ageValidator()inhackerAPI\middlewares\validators\validator.helper.jsto validate that age is between 0 and 100Commented out getAge function which calculates hackers' ages from their birthdate.
Type of change
How has this been tested?
The UI side of the dashboard seems to work since you can only input ages from 1 to 99.
Questions for code reviewers?
How to do more testing?
Checklist: